Pros
Some pros of being an EF teacher include decent salary, good training, and excellent support for lesson planning. Excellent support from headquarters regarding housing and visa paperwork. The centers in Moscow (for adults) are very cheerful and modern and nice to work in. The classes and events are very fun and the students are wonderful. Of the various different English-teaching companies working in Russia, it is my understanding that EF is among the best, if not THE best.
Cons
Some cons of being an EF teacher include tough hours (working late at night or early in the morning on weekends) and issues with management. My center director was a lovely person and a qualified manager. Friends of mine, however, had really terrible management (trouble with payment, reliable scheduling, and lack of training). So it could be a dice throw depending on where you are placed.