Pros
Can take pride in work. Can be trained in basic skill sets for unique jobs. Select units / MOS's have great training. Veteran's preference with select civilian jobs. Early retirement. Active duty is better than reserves. Some of the most honorable people in our country choose to work here.
Cons
Some of the least honorable people in our country also choose to work here. Extremely disorganized. Different departments are compartmentalized leading to miscommunication and many steps to accomplish simple tasks. Training is usually inadequate. Many MOS's don't actually do their jobs, instead contractors are paid to do it and you do other miscellaneous tasks. Veteran's preference isn't helpful without documented training and experience.