Pros
Aside from pride from serving your nation, financial stability and security are the main pros. It also has many perks, like health insurance and free tuition. It was interesting to experience other countries and cultures too.
Cons
There is a lot of senselessness to put up with, a lot of covering for people who can't pull their weight. When it comes to the Army, you have to remember that they let pretty much anyone in, and that anyone can make rank. The type of person you are will determine how you take that last statement. A big con for me is the archaic physical fitness program/body fat measurement method they use. Both are a very poor indicators of how fit you are. PRT barely test aerobic fitness and does nothing to improve anaerobic fitness. The tape test for body fat is the single most outdated body fat test there is. Other than that, if you are family oriented, it really isn't the occupation you need. The benefits make it appear great, but the time away takes it's toll. Especially on small children and marriages.